Replace float_deserialize feature with deserialize_via_float method #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSMaxB
force-pushed
the
remove-float-deserialize
branch
from
23ab4eb to
646294d
Compare
FSMaxB
force-pushed
the
remove-float-deserialize
branch
from
646294d to
155167b
Compare
jplatte
reviewed
Sep 14, 2025
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Oof, never submitted my review comment 😅
Co-authored-by: Max Bruckner <[email protected]>
jplatte
force-pushed
the
remove-float-deserialize
branch
from
155167b to
3caa141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
float_deserializefeature withInt::deserialize_via_floatandUInt::deserialize_via_floatmethods that can be used via#[serde(deserialize_with = ...)].This means that changing features will no longer silently change the behavior of the library.